Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure our attribute implementations are spec compliant #1340

Closed
dyladan opened this issue Jul 22, 2020 · 0 comments · Fixed by #1488
Closed

Ensure our attribute implementations are spec compliant #1340

dyladan opened this issue Jul 22, 2020 · 0 comments · Fixed by #1488
Assignees
@dyladan
Labels
good first issue Good for newcomers

Comments

@dyladan
Copy link
Member

dyladan commented Jul 22, 2020

open-telemetry/opentelemetry-specification#722

Spec now has a single definition for attributes shared with resources and traces. Where applicable, ensure that our span attributes and resource attributes conform to required limitations.
@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers release:required-for-ga labels Jul 22, 2020
@dyladan dyladan mentioned this issue Jul 29, 2020
Merged
@dyladan dyladan self-assigned this Jul 29, 2020
@dyladan dyladan changed the title [Audit] Ensure our attribute implementations are spec compliant Ensure our attribute implementations are spec compliant Sep 2, 2020
@dyladan dyladan mentioned this issue Sep 2, 2020
Merged
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 4, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
chore: release main (open-telemetry#1340)
63e0fc9
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
@dyladan
chore: release main (open-telemetry#1340)
85229ba
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 16, 2024
@dyladan
chore: release main (open-telemetry#1340)
b63830e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: ensure attributes are spec compliant dynatrace-oss-contrib/opentelemetry-js
1 participant
@dyladan