-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent loading plugins for incorrect module #626
Comments
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Dec 29, 2019
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 1, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 1, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 3, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 11, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 11, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Jan 11, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Feb 1, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Feb 8, 2020
vmarchaud
added a commit
to vmarchaud/opentelemetry-js
that referenced
this issue
Feb 12, 2020
dyladan
pushed a commit
that referenced
this issue
Feb 12, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this issue
Sep 9, 2022
…-telemetry#653) * fix: do not load plugin when they patch a different module than defined in config open-telemetry#626
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this issue
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #621, the following code sample is given as an example
Because the version matched, the plugin was loaded. PluginLoader should also check that the component name matches and emit an error log if the incorrect module name is detected. Instrumenting a plugin with the wrong library would be very dangerous.
The text was updated successfully, but these errors were encountered: