Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading plugins for incorrect module #626

Closed
dyladan opened this issue Dec 16, 2019 · 0 comments
Closed

Prevent loading plugins for incorrect module #626

dyladan opened this issue Dec 16, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dyladan
Copy link
Member

dyladan commented Dec 16, 2019

In #621, the following code sample is given as an example

  plugins: {
    mongodb: {
      enabled: true,
      path: '@opentelemetry/plugin-mongodb-core',
    },
  },

Because the version matched, the plugin was loaded. PluginLoader should also check that the component name matches and emit an error log if the incorrect module name is detected. Instrumenting a plugin with the wrong library would be very dangerous.

vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 29, 2019
@vmarchaud vmarchaud self-assigned this Dec 29, 2019
@vmarchaud vmarchaud added the enhancement New feature or request label Dec 29, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 1, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 1, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 3, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 11, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 11, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 11, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Feb 1, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Feb 8, 2020
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Feb 12, 2020
dyladan pushed a commit that referenced this issue Feb 12, 2020
* fix: do not load plugin when they patch a different module than defined in config #626
@dyladan dyladan closed this as completed Feb 12, 2020
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this issue Sep 9, 2022
…-telemetry#653)

* fix: do not load plugin when they patch a different module than defined in config open-telemetry#626
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants