fix: change default propagator to match spec #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahrosenblum
requested review from
bg451,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
approved these changes
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 122 122
Lines 3533 3533
Branches 714 714
=======================================
Hits 3262 3262
Misses 271 271
|
|
The lint will be fixed by #1217 |
mayurkale22
reviewed
Jun 18, 2020
| @@ -78,7 +83,9 @@ export class BasicTracerProvider implements api.TracerProvider { | |||
| register(config: SDKRegistrationConfig = {}) { | |||
| api.trace.setGlobalTracerProvider(this); | |||
| if (config.propagator === undefined) { | |||
| config.propagator = new HttpTraceContext(); | |||
| config.propagator = new CompositePropagator({ | |||
There was a problem hiding this comment.
Currently, HttpTraceContext is highlighted as a default propagator in the documentation (https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-core#built-in-propagators). Could you please update the same?
There was a problem hiding this comment.
Hi, I added a new commit to change the documentation. Thanks for pointing this out.
mayurkale22
reviewed
Jun 18, 2020
markwolff
approved these changes
Jun 18, 2020
mayurkale22
approved these changes
Jun 18, 2020
naseemkullah
approved these changes
Jun 19, 2020
mayurkale22
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Change the default propagator in the SDK to match what the spec requires.
Modify unit tests to reflect this change of default propagator.