-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: force flush and shutdown callback for span exporters #1296
Merged
dyladan
merged 6 commits into
open-telemetry:master
from
dynatrace-oss-contrib:force-flush-callback
Jul 13, 2020
Merged
feat: force flush and shutdown callback for span exporters #1296
dyladan
merged 6 commits into
open-telemetry:master
from
dynatrace-oss-contrib:force-flush-callback
Jul 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
July 9, 2020 18:00
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
- Coverage 93.24% 93.21% -0.03%
==========================================
Files 137 133 -4
Lines 3878 3891 +13
Branches 790 801 +11
==========================================
+ Hits 3616 3627 +11
- Misses 262 264 +2
|
lykkin
approved these changes
Jul 9, 2020
mwear
approved these changes
Jul 9, 2020
markwolff
approved these changes
Jul 9, 2020
mayurkale22
approved these changes
Jul 10, 2020
obecny
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just please fix the import vs require for sinon
packages/opentelemetry-tracing/test/export/BatchSpanProcessor.test.ts
Outdated
Show resolved
Hide resolved
Just looking at coverage it would be good to add more unit tests |
vmarchaud
approved these changes
Jul 11, 2020
mayurkale22
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Jul 12, 2020
This was referenced Dec 10, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1295 and is related to #1290