-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): remove x-opentelemetry-outgoing-request
header #1547
#1548
Conversation
73ad589
to
fa9e376
Compare
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
- Coverage 93.05% 92.92% -0.13%
==========================================
Files 158 156 -2
Lines 4882 4851 -31
Branches 988 978 -10
==========================================
- Hits 4543 4508 -35
- Misses 339 343 +4
|
fa9e376
to
27a4367
Compare
27a4367
to
7279b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just wondering if some of tests could be converted using the new "suppress" feature now, WDYT ?
Well i hesitated about that but since the supress feature is only implement in the tracing sdk, i would find it weird to add tests for that in the instrumentation, but i'm open to add some if anyone find it really important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to see this being removed!
Fixes #1547