chore: use performance directly in xhr plugin #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 165 165
Lines 5042 5042
Branches 1040 1040
=======================================
Hits 4606 4606
Misses 436 436
|
dyladan
force-pushed
the
use-performance
branch
from
589c421
to
c8ac759
Compare
obecny
approved these changes
Nov 6, 2020
mwear
approved these changes
Nov 9, 2020
1 task
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks #1451
Latest version of
@types/nodedoes not haveperformance.getEntriesByType(), but it still exists in the browser globalperformance.Using
performancedirectly is safe in the xhr plugin because it will not be used in node.