feat(grpc-instrumentation): migrate grpc to instrumentation #1656

[vmarchaud]

I needed few modifications of the base instrumentation to got the grpc plugin, they should be backward compatible except for the InstrumentationModuleFile constructor where i added supportedVersions as the second arguemnt to match InstrumentationNodeModuleFile.

As asked here, i think it would make sense to have both grpc/grpc-js in the same instrumentation, so i added the test suite from the grpc-utils package into this one while waiting to migrate grpc-js.

[codecov]

Codecov Report

Merging #1744 (be1f987) into master (042a99a) will decrease coverage by 0.14%.
The diff coverage is 85.13%.

@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
- Coverage   92.30%   92.16%   -0.15%     
==========================================
  Files         163      167       +4     
  Lines        5510     5845     +335     
  Branches     1188     1256      +68     
==========================================
+ Hits         5086     5387     +301     
- Misses        424      458      +34     

Impacted Files	Coverage Δ
...strumentation/src/platform/node/instrumentation.ts	6.66% <0.00%> (-0.19%)	⬇️
...atform/node/instrumentationNodeModuleDefinition.ts	14.28% <0.00%> (ø)
...src/platform/node/instrumentationNodeModuleFile.ts	20.00% <0.00%> (-5.00%)	⬇️
...ges/opentelemetry-instrumentation-grpc/src/grpc.ts	92.52% <92.52%> (ø)
...es/opentelemetry-instrumentation-grpc/src/utils.ts	93.93% <93.93%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts	87.50% <0.00%> (-6.25%)	⬇️
...es/opentelemetry-context-zone-peer-dep/src/util.ts	100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts	85.18% <0.00%> (ø)

[obecny]

@vmarchaud should we wait until you add grpc-js too ?

[vmarchaud]

@obecny I prefer to split this into two PR

[obecny]

@obecny I prefer to split this into two PR

whatever will be easier.

[obecny]

few issue with status code, other than that lgtm

[obecny]

Nit: split this into 2 new internal function for better readability for example

private _getInternalPatchs() {
    return [
      this.patchClientVerTill1_6,
      this.patchClientVerAbove1_6,
    ]

[vmarchaud]

Since both patches were using the same duplicated code, i prefered to declare both onPatch and onUnPatch and just re-use them. PTAL

[dyladan]

Looks good thanks

[obecny]

lgtm