-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tracer-web example webpack config #2326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the line in question was added by @obecny ac81e17#diff-2337895425ca89703bc0c2d23649b18aefb5fd5259db29452dcedac8d3625f0bR11
Looks good to me but I want his approval before this merges in case we're missing something.
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 145 145
Lines 5216 5216
Branches 1068 1068
=======================================
Hits 4839 4839
Misses 377 377 |
@dyladan Sounds good to me, I spent maybe 10 mins trying to understand it so by no means do I think I got to the root of it. |
Interestingly, it was a |
it was probably copied or modified from one of the other packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was file I was using for testing some changes temporary, can be removed, thx
Which problem is this PR solving?
npm start
fails #2325Short description of the changes