Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release-please automation #2393

Closed
wants to merge 15 commits into from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 3, 2021

Release automation from https://github.com/googleapis/release-please

As of now, this will only create release PRs based on conventional commits. It will still be up to maintainers to actually push the release to NPM after it is merged. After we are sure the bot is doing what we are expecting, the github action will be extended to actually push releases to NPM automatically.

Changes:

  • Remove version.ts files
  • Add version.ts files to gitignore
  • Generate version.ts files on precompile step
  • Add manifest file to tell release-please what the most recent version of each package is
  • Add config file to tell release-please where to find each package
  • Change lerna version to "independent"
  • root package.json version is no longer relevant since packages could have different versions
  • Add release-please github action

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2393 (a789090) into main (f129138) will increase coverage by 0.51%.
The diff coverage is n/a.

❗ Current head a789090 differs from pull request most recent head 7c57925. Consider uploading reports for the commit 7c57925 to get more accurate results

@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
+ Coverage   92.14%   92.66%   +0.51%     
==========================================
  Files         120      137      +17     
  Lines        3998     4975     +977     
  Branches      844     1048     +204     
==========================================
+ Hits         3684     4610     +926     
- Misses        314      365      +51     
Impacted Files Coverage Δ
...ry-exporter-collector/src/CollectorExporterBase.ts 92.15% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.91% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
... and 8 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (except gha name)

@dyladan dyladan requested a review from a team August 9, 2021 13:06
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

package.json Show resolved Hide resolved
@dyladan dyladan linked an issue Aug 16, 2021 that may be closed by this pull request
@dyladan
Copy link
Member Author

dyladan commented Aug 16, 2021

Waiting on open-telemetry/community#809

@dyladan dyladan closed this Aug 26, 2021
@dyladan dyladan deleted the release-please branch August 26, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lerna independent versioning
6 participants