Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: expose existing comments #2555

Merged
merged 2 commits into from
Oct 22, 2021
Merged

docs: expose existing comments #2555

merged 2 commits into from
Oct 22, 2021

Conversation

moander
Copy link
Contributor

@moander moander commented Oct 20, 2021

No description provided.

@moander moander requested a review from a team October 20, 2021 20:16
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #2555 (059634f) into main (6a8c2f2) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 059634f differs from pull request most recent head 3f69933. Consider uploading reports for the commit 3f69933 to get more accurate results

@@            Coverage Diff             @@
##             main    #2555      +/-   ##
==========================================
+ Coverage   93.05%   93.08%   +0.02%     
==========================================
  Files         140       58      -82     
  Lines        5172     1894    -3278     
  Branches     1111      408     -703     
==========================================
- Hits         4813     1763    -3050     
+ Misses        359      131     -228     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
...ry-instrumentation-grpc/src/grpc-js/serverUtils.ts
...es/opentelemetry-propagator-b3/src/B3Propagator.ts
...ntelemetry-sdk-metrics-base/src/HistogramMetric.ts
...sync-hooks/src/AbstractAsyncHooksContextManager.ts
... and 78 more

@obecny
Copy link
Member

obecny commented Oct 21, 2021

can you please add some description so it gives better context - I think there should be a template when you create a new PR .

@moander
Copy link
Contributor Author

moander commented Oct 21, 2021

@obecny sorry I thought the commit spoke for it self. I just changed // to /** so the comment becomes visible in editors.

@obecny
Copy link
Member

obecny commented Oct 21, 2021

@obecny sorry I thought the commit spoke for it self. I just changed // to /** so the comment becomes visible in editors.

I meant here in PR, so when someone enter this, the description will help to understand what is this about without opening the code changes

@obecny
Copy link
Member

obecny commented Oct 22, 2021

@moander pls don't force push after any1 will review, it is impossible to see changes anymore

@rauno56
Copy link
Member

rauno56 commented Oct 22, 2021

There are editors that hide //-type comments?

@obecny obecny merged commit b531acf into open-telemetry:main Oct 22, 2021
@obecny obecny added the document Documentation-related label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants