-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-metrics): bootstrap metric streams #2636
Conversation
1088cca
to
da450e4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 93.29% 92.86% -0.44%
==========================================
Files 131 143 +12
Lines 4923 5158 +235
Branches 1078 1102 +24
==========================================
+ Hits 4593 4790 +197
- Misses 330 368 +38
|
da450e4
to
e06ae29
Compare
to those @open-telemetry/javascript-approvers who didn't see, this is now ready for review. |
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricReader.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricExporter.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MeterProviderSharedState.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a quick pass and overall looks fine from my comprehension of the spec, i will try to review it a second time though before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits from my side.
Which problem is this PR solving?
This is a prototype of the synchronous metric streams implementation described in https://docs.google.com/document/d/1EluDhj5UanNATS3hR8xx30sv55Se7uYjsGYslvNWHtc/edit#.
Bootstrap metric streams:
Related: #2574
Depends on: #2634
Type of change
How Has This Been Tested?
Checklist: