feat(sdk-metrics-base): async instruments callback timeout #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2742 +/- ##
=======================================
Coverage 92.51% 92.52%
=======================================
Files 183 183
Lines 5959 5980 +21
Branches 1266 1268 +2
=======================================
+ Hits 5513 5533 +20
- Misses 446 447 +1
|
legendecas
force-pushed
the
metrics-ff/async-timeout
branch
from
240e96c to
011e528
Compare
pichlermarc
reviewed
Jan 27, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/state/AsyncMetricStorage.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR is not stale it is just still waiting on a spec clarification which has not yet been closed. |
|
The spec change has been merged: open-telemetry/opentelemetry-specification#2495. I'm going to pick this up. |
This comment was marked as outdated.
This comment was marked as outdated.
7 tasks
legendecas
force-pushed
the
metrics-ff/async-timeout
branch
2 times, most recently
from
3e7b382 to
56cb7a5
Compare
legendecas
force-pushed
the
metrics-ff/async-timeout
branch
from
56cb7a5 to
05b0e6e
Compare
4 tasks
dyladan
approved these changes
May 9, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricData.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/state/ObservableRegistry.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
May 10, 2022
pichlermarc
reviewed
May 11, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricData.ts
Outdated
Show resolved
Hide resolved
…meout # Conflicts: # experimental/packages/opentelemetry-sdk-metrics-base/src/state/MeterSharedState.ts # experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricCollector.ts # experimental/packages/opentelemetry-sdk-metrics-base/test/export/PeriodicExportingMetricReader.test.ts # experimental/packages/opentelemetry-sdk-metrics-base/test/state/MetricCollector.test.ts
…meout-stage # Conflicts: # experimental/CHANGELOG.md # experimental/packages/opentelemetry-sdk-metrics-base/test/util.ts
pichlermarc
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Apply timeout option directly to each async instrument callback to gain finer grain control over timeout. With open-telemetry/opentelemetry-specification#2295 being clarified, we can export successfully collected metric data even if a single async instrument callback is timed out.
Type of change
How Has This Been Tested?
Checklist: