-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc compression to trace-otlp-grpc exporter #2813
Add grpc compression to trace-otlp-grpc exporter #2813
Conversation
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2813 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 163 163
Lines 5572 5572
Branches 1180 1180
=======================================
Hits 5211 5211
Misses 361 361 |
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
…ntelemetry-js into add-grpc-compression
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits.
packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks good to me % the same nits as legendecas
Co-authored-by: legendecas <legendecas@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Which problem is this PR solving?
Add gzip compression to OTLP/gRPC trace exporter.
Partially Fixes #2706 (issue)
Short description of the changes
Added compression configuration that will select the compression set by the user (through configuration options or environment variables). Added compression to service client in
onInit
method inutils.js
.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: