Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc compression to trace-otlp-grpc exporter #2813

Merged
merged 18 commits into from
Mar 22, 2022

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Mar 2, 2022

Which problem is this PR solving?

Add gzip compression to OTLP/gRPC trace exporter.

Partially Fixes #2706 (issue)

Short description of the changes

Added compression configuration that will select the compression set by the user (through configuration options or environment variables). Added compression to service client in onInit method in utils.js.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • unit tests
  • integration test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
@svetlanabrennan svetlanabrennan requested a review from a team March 2, 2022 22:14
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #2813 (77ea22c) into main (3fd1b1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2813   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         163      163           
  Lines        5572     5572           
  Branches     1180     1180           
=======================================
  Hits         5211     5211           
  Misses        361      361           

Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

packages/exporter-trace-otlp-grpc/src/util.ts Outdated Show resolved Hide resolved
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me % the same nits as legendecas

@dyladan dyladan added the enhancement New feature or request label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlp exporters: missing some environment variables from spec in SDK
4 participants