Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct changelog and compat matrix for 1.1 release #2849

Merged
merged 5 commits into from
Mar 22, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Mar 21, 2022

Which problem is this PR solving?

Short description of the changes

OTLP exporters have been moved back to experimental therefore the corresponding breaking change will be in 0.28.0.

Corrected compat matrix as SDK 1.0 uses API 1.0 and SDK 1.1 use API 1.1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

OTLP exporters have been moved back to experimental therefore the corresponding breaking change
will be in 0.28.0.

Corrected compat matrix as SDK 1.0 uses API 1.0 and SDK 1.1 use API 1.1.
@Flarna Flarna requested a review from a team March 21, 2022 15:28
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #2849 (9aed977) into main (68b93c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2849   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         163      163           
  Lines        5572     5572           
  Branches     1180     1180           
=======================================
  Hits         5211     5211           
  Misses        361      361           

@Flarna
Copy link
Member Author

Flarna commented Mar 21, 2022

by the way, the release holds also the non existing breaking change. Should we remove it there also?

@dyladan
Copy link
Member

dyladan commented Mar 21, 2022

@Flarna you were the one that added the breaking label. Why is it that you now believe it was not breaking?

edit: I see it was a component that wasn't a part of the release. I'll update the release notes.

@dyladan
Copy link
Member

dyladan commented Mar 21, 2022

I don't see the changelog modified in this PR. Do you have unpushed local commits?

@Flarna
Copy link
Member Author

Flarna commented Mar 21, 2022

I don't see the changelog modified in this PR. Do you have unpushed local commits?

nope, just forgot to adapt it.

@legendecas legendecas merged commit 2cb620d into open-telemetry:main Mar 22, 2022
@Flarna Flarna deleted the readme_1.1.0 branch March 22, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants