-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-sdk): add serviceName config option #2867
feat(node-sdk): add serviceName config option #2867
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2867 +/- ##
==========================================
- Coverage 92.64% 92.09% -0.55%
==========================================
Files 187 82 -105
Lines 6169 2405 -3764
Branches 1303 520 -783
==========================================
- Hits 5715 2215 -3500
+ Misses 454 190 -264
|
b1506a7
to
3f92f1f
Compare
b615465
to
4214cb9
Compare
OK, now back to original proposal of just adding a |
4214cb9
to
363c665
Compare
363c665
to
15cf5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15cf5b6
to
a95577c
Compare
a95577c
to
c89cdd9
Compare
Which problem is this PR solving?
Fixes #2799
configure service name directly in the node SDK config
Short description of the changes
add optional serviceName option in node SDK constructor, which behind the scenes creates another resource that is merged with any one that may have been passed in. this occurs after autoDetectResources so that the in code config set service name trumps any env set service name
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: