-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation): use all provided filepatches #2963
Conversation
53adf00
to
29ff7be
Compare
Codecov Report
@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
- Coverage 92.66% 92.65% -0.02%
==========================================
Files 187 187
Lines 6174 6178 +4
Branches 1305 1304 -1
==========================================
+ Hits 5721 5724 +3
- Misses 453 454 +1
|
1728496
to
68dc7e9
Compare
98defc5
to
b185c29
Compare
I reran the browser test and it still failed in the same way. weird because this doesn't touch any browser code. |
A different test is failing each time: I've also tried running it locally multiple times, but sadly, all the tests pass. :( |
I think, I have a fix for these tests here: #2969 |
e6d96cb
to
c0d9629
Compare
c0d9629
to
06cf773
Compare
Which problem is this PR solving?
Fixes the issue when only the first
InstrumentationNodeModuleFile
for each path is applied.Fixes #2355
Short description of the changes
Filter and apply all
InstrumentationNodeModuleFile
s instead of just finding the first.Type of change
How Has This Been Tested?
InstrumentationNodeModuleFile
targeting the same fileChecklist: