Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-transformer): include esm and esnext in package files and update README #2992

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Previously the esm and esnext files were not included in the otlp-transformer package even though their corresponding entry points were defined package.json.

This PR also updates the README.md file of this package to drop information about not implemented features.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #2992 (99dd245) into main (bfd04b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files         183      183           
  Lines        6134     6134           
  Branches     1299     1299           
=======================================
  Hits         5687     5687           
  Misses        447      447           

@pichlermarc pichlermarc changed the title fix(otlp-transformer): include esm and esnext in package files and update README. fix(otlp-transformer): include esm and esnext in package files and update README May 25, 2022
@pichlermarc pichlermarc marked this pull request as ready for review May 25, 2022 10:19
@pichlermarc pichlermarc requested a review from a team May 25, 2022 10:19
@dyladan dyladan mentioned this pull request May 26, 2022
3 tasks
@dyladan dyladan merged commit 7149f6c into open-telemetry:main May 27, 2022
@dyladan dyladan deleted the include-esm-exsnext branch May 27, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants