Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otlp-proto-exporter-base): update protobufjs to 7.1.2 #3433

Merged
merged 3 commits into from
Nov 22, 2022
Merged

chore(otlp-proto-exporter-base): update protobufjs to 7.1.2 #3433

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5020802
chore(otlp-proto-exporter-base): update protobufjs to 7.1.2
seemk Nov 21, 2022
6282882
chore: update changelog
seemk Nov 21, 2022
06a4969
Merge branch 'main' into update-otlp-proto-exporter-protobuf-7.1.2
seemk Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ All notable changes to experimental packages in this project will be documented

### :house: (Internal)

* chore(otlp-proto-exporter-base): upgrade protobufjs to 7.1.2 and relax versioning [#3433](https://github.com/open-telemetry/opentelemetry-js/pull/3433) @seemk

## 0.34.0

* `@opentelemetry/sdk-metrics` moved to [packages/sdk-metrics](../packages/sdk-metrics)
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/otlp-proto-exporter-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"dependencies": {
"@opentelemetry/core": "1.8.0",
"@opentelemetry/otlp-exporter-base": "0.34.0",
"protobufjs": "7.1.1"
"protobufjs": "^7.1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot will just open a PR to pin this if you don't change the config. Also, it was an intentional choice to pin dependencies so that our users can effectively pin.

Copy link
Contributor Author

@seemk seemk Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently installing @opentelemetry/exporter-trace-otlp-grpc and @opentelemetry/exporter-trace-otlp-proto side by side brings in 2 different protobufjs versions: 7.1.1 and 7.1.2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the problem here is that we can not effectively pin indirect dependencies like @grpc/grpc-js -> @grpc/proto-loader -> protobufjs ^7.0.0.

I noticed that the dependencies on @grpc/grpc-js are declared as caret range, e.g. https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/exporter-trace-otlp-grpc/package.json#L71. So I'd find it should be fine for us to apply caret range for protobufjs too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we pin only dev-dependencies and the otel dependencies which are from same lerna project (and therefore released together).
e.g. @opentelemetry/exporter-jaeger depends on "jaeger-client": "^3.15.0", @opentelemetry/instrumentation depends on "require-in-the-middle": "^5.0.3", "semver": "^7.3.2" and "shimmer": "^1.2.1".

},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/otlp-proto-exporter-base",
"sideEffects": false
Expand Down