fix(resources): change fs/promises import to be node 12 compatible #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
approved these changes
Mar 16, 2023
dyladan
approved these changes
Mar 16, 2023
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Mar 16, 2023
…pen-telemetry#3681) * fix(resources): change fs/promises import to be node 12 compatible * fix(changelog): add changelog entry.
Merged
7 tasks
dyladan
added a commit
that referenced
this pull request
Mar 20, 2023
* fix(resource): make properties for async resource resolution optional (#3677) * fix(resource): make properties for async resolution optional * fix(changelog): add changelog * fix(resources): add regression test * fix(resources): remove ts-ignore in tests --------- Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * Changelog * Bump patch versions * fix(resources): change fs/promises import to be node 12 compatible (#3681) * fix(resources): change fs/promises import to be node 12 compatible * fix(changelog): add changelog entry. --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR changes the import according to nodejs/node#35740 (comment) to make the default detectors work again with Node.js v12.
Note: Node.js <14 remains unsupported by this project.
Fixes #3673
Short description of the changes
Type of change
How Has This Been Tested?
Note: CI does not run for Node 12
Checklist: