Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency require-in-the-middle to v7 #3782

Merged

Conversation

renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
require-in-the-middle ^6.0.0 -> ^7.0.0 age adoption passing confidence

Release Notes

elastic/require-in-the-middle

v7.1.0

Compare Source

v7.0.1

Compare Source

  • Fix hooking of 'http2' with Node.js versions [8.0, 8.8) where the 'http2'
    built-in module was behind the --expose-http2 flag.
    https://github.com/elastic/require-in-the-middle/pull/68l/68)
    Release v7.0.0 introduced a bug with this case where the process would crash with:

    AssertionError [ERR_ASSERTION]: unexpected that there is no Module entry for "http2" in require.cache
      at ExportsCache.set (.../require-in-the-middle4/index.js:72:7)
    

v7.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team May 5, 2023 00:37
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3782 (54b62be) into main (8fc7689) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 54b62be differs from pull request most recent head 327fffb. Consider uploading reports for the commit 327fffb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3782      +/-   ##
==========================================
- Coverage   93.24%   93.13%   -0.12%     
==========================================
  Files         285      296      +11     
  Lines        8230     9015     +785     
  Branches     1709     1853     +144     
==========================================
+ Hits         7674     8396     +722     
- Misses        556      619      +63     

see 16 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabmass FYI

If you approve, then I'll merge this. The API stays mostly the same, we just had some problems previously with v6 (see #3701), I think the same problem from that issue would also affect future opencensus-shim PRs (see #3778 (files)).

@renovate-bot renovate-bot force-pushed the renovate/require-in-the-middle-7.x branch from df55418 to cdb448e Compare May 9, 2023 05:06
@renovate-bot renovate-bot force-pushed the renovate/require-in-the-middle-7.x branch from cdb448e to 327fffb Compare May 11, 2023 13:10
@dyladan dyladan merged commit 17eca4c into open-telemetry:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants