Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otlp-grpc-exporters): Add support for Unix domain socket endpoints. #3853

Merged
merged 19 commits into from
Jun 20, 2023

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented Jun 2, 2023

Short description of the changes

Currently the OTLP gRPC exporters only support http endpoints. This PR adds support for UDS endpoints.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@llc1123 llc1123 marked this pull request as ready for review June 2, 2023 09:35
@llc1123 llc1123 requested a review from a team June 2, 2023 09:35
@llc1123 llc1123 changed the title [otlp-grpc-exporter] Support Unix domain socket as endpoint feat(otlp-grpc-exporters): Add support for Unix domain socket endpoints. Jun 2, 2023
@llc1123 llc1123 force-pushed the feat/otlp-grpc-uds branch from 95a1b2d to e4aaa25 Compare June 2, 2023 09:36
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #3853 (1133307) into main (67d4b80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1133307 differs from pull request most recent head 47fe3c9. Consider uploading reports for the commit 47fe3c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3853   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         297      297           
  Lines        8836     8838    +2     
  Branches     1814     1815    +1     
=======================================
+ Hits         8207     8209    +2     
  Misses        629      629           
Impacted Files Coverage Δ
...ental/packages/otlp-grpc-exporter-base/src/util.ts 76.37% <100.00%> (+0.37%) ⬆️

@llc1123 llc1123 force-pushed the feat/otlp-grpc-uds branch from e4aaa25 to a0e209b Compare June 2, 2023 09:47
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM % one nits.

@legendecas legendecas merged commit f40e3de into open-telemetry:main Jun 20, 2023
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Jun 26, 2023
…ts. (open-telemetry#3853)

* feat(otlp-grpc-exporter-base): add support for unix domain socket

* test(otlp-grpc-exporter): add tests

* chore(docs): update docs and changelog

* fix: skip UDS tests on windows

* Update CHANGELOG.md

* fix: add protocol to http test urls

* fix: update tests

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@llc1123 llc1123 deleted the feat/otlp-grpc-uds branch June 26, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants