-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LowMemory metrics temporality preference #3915
LowMemory metrics temporality preference #3915
Conversation
2e5b58b
to
814294e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
+ Coverage 92.30% 93.14% +0.84%
==========================================
Files 286 298 +12
Lines 8286 8869 +583
Branches 1713 1826 +113
==========================================
+ Hits 7648 8261 +613
+ Misses 638 608 -30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thanks for taking the time to add this 🙂
Implementation looks great, but I think we should highlight that this is a breaking change.
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
I know these packages are still not version '1' so breaking changes are not a huge deal, but I believe we can just support both AggregationTemporalitySelector and AggregationTemporality without to much trouble here, being one a subset of the other. |
I'd also be in favor of that - while we make no stability guarantees for experimental packages, supporting both would probably be helpful for users. |
@hectorhdzg @pichlermarc Can you please let me know what exactly you have in mind? Enums cannot be combined directly, so do you mean converting the two enums to something like const objects or types to allow making one subset of the other? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which problem is this PR solving?
This adds the LowMemory option for the OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE configuration. This is defined in the spec here.
Fixes #3818
Short description of the changes
This PR adds a new AggregationTemporalitySelector with mapping between instrument types and aggregation temporality. It also adds the new AggregationTemporalityPreference type to allow for the new value to be passed in configuration.
Type of change
Please delete options that are not relevant.
Checklist: