Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otlp-exporters): bump otlp proto to 0.20.0 #3932

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 21, 2023

Which problem is this PR solving?

This PR bumps https://github.com/open-telemetry/opentelemetry-proto for the OTLP exporters to 0.20.0 (previously we were at 0.18.0).

Fixes #3870
OTLP features added by this PR will be implemented in #3392, #3183

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • Manual testing against latest collector (0.80.0)

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #3932 (4d93c63) into main (5dc0f69) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 4d93c63 differs from pull request most recent head 035e049. Consider uploading reports for the commit 035e049 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3932      +/-   ##
==========================================
- Coverage   92.91%   92.89%   -0.03%     
==========================================
  Files         297      297              
  Lines        8838     8838              
  Branches     1815     1815              
==========================================
- Hits         8212     8210       -2     
- Misses        626      628       +2     
Impacted Files Coverage Δ
...-grpc-exporter-base/src/LogsExportServiceClient.ts 42.85% <ø> (ø)
...pc-exporter-base/src/MetricsExportServiceClient.ts 42.85% <ø> (ø)
...grpc-exporter-base/src/TraceExportServiceClient.ts 42.85% <ø> (ø)
...mental/packages/otlp-transformer/src/logs/types.ts 100.00% <ø> (ø)
...tal/packages/otlp-transformer/src/metrics/types.ts 100.00% <ø> (ø)
...ental/packages/otlp-transformer/src/trace/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review June 21, 2023 11:39
@pichlermarc pichlermarc requested a review from a team June 21, 2023 11:39
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for updating this!

@pichlermarc pichlermarc merged commit 19fb033 into open-telemetry:main Jun 21, 2023
@pichlermarc pichlermarc deleted the feat/otlp-0.20.0 branch June 21, 2023 18:27
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OTLP to 0.20.0
3 participants