-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-node): logs support added #3969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something went wrong with the new versions we published a few moments ago.
made all required changes |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
+ Coverage 92.29% 92.31% +0.02%
==========================================
Files 320 321 +1
Lines 9145 9189 +44
Branches 1939 1953 +14
==========================================
+ Hits 8440 8483 +43
- Misses 705 706 +1
|
Please also add an entry in |
Please link #3826 to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few more comments to address then we can get this merged. 🙂
thanks for suggestions @pichlermarc , made all required changes |
Which problem is this PR solving?
Logs support is added in sdk-node package.
Fixes #3826
Short description of the changes
Dependencies added in package.json
Feature added in sdk file
Tests added
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: