Move xray propagator from contrib #4544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add xray propagator * chore: cleanups * Remove AWS Distro link Co-authored-by: Valentin Marchaud <thisismac47@gmail.com>
Co-authored-by: vmarchaud <vmarchaud@users.noreply.github.com>
* feat: add ESM builds for packages used in browser * fix(id-generator-aws-xray): missed including esm files
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
* chore: update core to 0.20.0 * chore: fix test * chore: review comments and lint * chore: get example versions from previous update * chore: lint
Co-authored-by: dyladan <dyladan@users.noreply.github.com>
* chore: move api into peer dependency * fix peer-api-check script
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Co-authored-by: vmarchaud <vmarchaud@users.noreply.github.com> Co-authored-by: vmarchaud <contact@vmarchaud.fr>
* chore: 0.22.0 release proposal * chore: changelog Co-authored-by: dyladan <dyladan@users.noreply.github.com>
* chore: 0.23.0 release proposal * chore: changelog Co-authored-by: obecny <obecny@users.noreply.github.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: dyladan <dyladan@users.noreply.github.com>
martinkuba
force-pushed
the
move-xray-propagator
branch
from
bbe5b8d to
1b4999f
Compare
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
+ Coverage 92.83% 92.91% +0.07%
==========================================
Files 328 329 +1
Lines 9481 9577 +96
Branches 2031 2057 +26
==========================================
+ Hits 8802 8898 +96
Misses 679 679
|
8 tasks
|
@pichlermarc I have opened to two alternative PRs to this one
Please let me know which of these three PRs makes most sense to pursue. |
|
Closing in favor of #4603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #4494
It should be possible to configure the
xraypropagator using theOTEL_PROPAGATORSenv variable. This is currently documented here, and it is also part of the lambda spec.This was discussed in the SIG meeting on 1/31/24 and decided that the propagator should be moved from contrib to here. This will then make it possible to hardcode the mapping of the name
xrayto the AWSXrayPropagator implementation in the BasicTracerProvider.fyi @carolabadeer (as the maintainer of this component in https://github.com/open-telemetry/opentelemetry-js-contrib)
Note about history -
This PR includes the commit history from the contrib repository for any changes made to these files. The upside is that it preserves the history of the original authors. The downside is that many chore commits were brought over as well (including contrib release commits). The commit messages also include links to PRs in the
opentelemetry-js-contribthat are no longer valid in the context of theopentelemetry-jsrepository. I think this is similar to what was done when the API was moved (the links in this PR are also invalid).As an alternative, I could open this PR without the history, or I could selectively remove commits we do not want to bring over.