Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-node)!: remove long deprecated methods in favor of constructor options #4609

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

This simplifies the API and internal logic for NodeSDK. Removes deprecated methods in favor of constructor options.

Breaking changes:

  • removed NodeSDK.configureTracerProvider(), please use constructor options instead
  • removed NodeSDK.configureMeterProvider(), please use constructor options instead
  • removed NodeSDK.configureLoggerProvider(), please use constructor options instead
  • removed NodeSDK.addResource(), please use constructor options instead
  • removed NodeSDK.detectResources(), this is not necessary anymore, resources are now auto-detected on NodeSDK.start() if the constructor option autoDetectResources is unset, undefined or true.

Follows up on #3996

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Existing tests

@pichlermarc pichlermarc force-pushed the feat/remove-deprecated-methods branch from c25cae7 to 15937bd Compare April 5, 2024 15:14
@pichlermarc pichlermarc changed the title Feat/remove deprecated methods feat(sdk-node)!: remove long deprecated methods in favor of constructor options Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #4609 (15937bd) into main (c046867) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4609      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.03%     
==========================================
  Files         329      329              
  Lines        9528     9497      -31     
  Branches     2053     2042      -11     
==========================================
- Hits         8845     8820      -25     
+ Misses        683      677       -6     
Files Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 96.03% <100.00%> (+3.61%) ⬆️

@pichlermarc pichlermarc marked this pull request as ready for review April 5, 2024 15:22
@pichlermarc pichlermarc requested a review from a team April 5, 2024 15:22
@pichlermarc pichlermarc merged commit 7fb673c into open-telemetry:main Apr 10, 2024
10 of 11 checks passed
@pichlermarc pichlermarc deleted the feat/remove-deprecated-methods branch April 10, 2024 11:31
legalimpurity pushed a commit to legalimpurity/opentelemetry-js that referenced this pull request Apr 26, 2024
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants