-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare release API 1.9.0/Core 1.25.0/Experimental 0.52.0 #4677
chore: prepare release API 1.9.0/Core 1.25.0/Experimental 0.52.0 #4677
Conversation
7d5305c
to
715ecb2
Compare
I reached out to Datadog about this through @Qard. As the PR currently stands it would break dd-trace which I would like to avoid. I think we should delay this for a short time in order to allow them to respond, but I don't want to delay it forever. |
I've forwarded it to the relevant person internally so hopefully we'll come up with some solution soon... |
Any chance of #4536 enhancement having a published release soon? I realize there's a breaking change with a dd lib but was hoping to have the enhancement in a release sooner than that's resolved? Appreciate everyone's efforts here. |
@Qard @dyladan Any chance the dd-trace blockers don't hold back API 1.9.0 enhancements? Is it possible to have a release for API without waiting on dd-trace resolution? Thank you in advance! |
It's possible but it's not ideal. If we release in the current state we will definitely break dd-trace and it reflects poorly on the project. We're doing our best to work with them. Sorry it's delaying the release but please be patient and we'll have a release soon. |
We're going to move forward with this change next week. It looks to me like dd-trace hasn't done anything yet to address the issue, but we have been very clear for months. @pichlermarc please update this PR and we can get it merged when I get back. |
764f659
to
f36161f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
- Coverage 91.04% 89.81% -1.24%
==========================================
Files 89 147 +58
Lines 1954 3220 +1266
Branches 416 699 +283
==========================================
+ Hits 1779 2892 +1113
- Misses 175 328 +153 |
6554b25
to
3dccbe2
Compare
@open-telemetry/javascript-approvers this release PR is now unblocked:
|
3dccbe2
to
8b86d80
Compare
There's an unreleased bug on main (missing dependency), fixed by #4732. |
@pichlermarc Is there a need/reason to avoid publishing this propagator from the core repo? I suppose it is fine. It can be moved and published from contrib repo later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts to sort out, and I asked a Q above about the new AWS Xray Lambda propagator package.
It's not spec compliant but I think it's fine for now. We can move it to contrib at any time and be spec compliant again. |
8b86d80
to
fedda85
Compare
fedda85
to
c619695
Compare
…n-telemetry#4677) * chore: prepare release * fixup! chore: prepare release * chore: sync package-lock.json
1.9.0
🚀 (Enhancement)
1.25.0
🚀 (Enhancement)
📚 (Refine Doc)
0.52.0
💥 Breaking Change
@opentelemetry/otlp-transformer
#4542 @pichlermarcconvert()
now returns an empty object and will be removed in a follow-upResponseType
type parameter@opentelemetry/otlp-transformer
#4581 @pichlermarcconvert()
has been removed from all exportersRequestType
has been replaced by aResponseType
type-argumentServiceRequest
has been replaced by aServiceResponse
type-argument@opentelemetry/otlp-exporter-proto-base
package has been removed, and will from now on be deprecated innpm
registerInstrumentations()
APIInstrumentationOptions
typeInstrumentationOptions
are now replaced by(Instrumentation | Instrumentation[])[]
registerInstrumentations({instrumentations: fooInstrumentation})
toregisterInstrumentations({instrumentations: [fooInstrumentation]})
registerInstrumentations()
is now not possible anymore.instrumentations
optionInstrumentationOptions
with(Instrumentation | Instrumentation[])[]
🚀 (Enhancement)
🐛 (Bug Fix)
import-in-the-middle
to fix numerous bugs #4745 @timfish📚 (Refine Doc)