fix(otlp-exporter-base): fix handling of destroyed requests #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
changed the title
pichlermarc
commented
Aug 19, 2024
Comment on lines
-28
to
-31
| export const DEFAULT_EXPORT_INITIAL_BACKOFF = 1000; | ||
| export const DEFAULT_EXPORT_MAX_BACKOFF = 5000; | ||
| export const DEFAULT_EXPORT_BACKOFF_MULTIPLIER = 1.5; | ||
|
|
There was a problem hiding this comment.
reviewer note: this is unrelated. They're not used anymore, so I decided to remove them.
Comment on lines
+579
to
+586
| try { | ||
| assert.strictEqual(result.code, core.ExportResultCode.FAILED); | ||
| const error = result.error as OTLPExporterError; | ||
| assert.ok(error !== undefined); | ||
| assert.strictEqual(error.message, 'Request Timeout'); | ||
| } catch (e) { | ||
| done(e); | ||
| } |
There was a problem hiding this comment.
reviewer note: i changed this test as to ensure it does not show up as timed out when assertions fail.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4929 +/- ##
==========================================
- Coverage 93.29% 92.89% -0.41%
==========================================
Files 84 317 +233
Lines 1700 8243 +6543
Branches 349 1675 +1326
==========================================
+ Hits 1586 7657 +6071
- Misses 114 586 +472
|
pichlermarc
added
bug
trentm
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is an unreleased bug, therefore not adding a changelog entry.
Priority: P3 (logspam)
A destroyed request is currently treated as never successful and therefore always times out, which causes the PeriodicExportingMetricReader to log an error, even though the request itself was successful.
This PR fixes this issue and adds tests for
HttpExporterTransport, added in #4743.Type of change
How Has This Been Tested?