Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exporter-zipkin): remove usages of Span constructor #5030

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

The Span constructor from ' @opentelemetry/sdk-trace-base` is planned for removal from the public API . This PR anticipates the possible breaking changes derived from it

Refs #3597

Short description of the changes

  • Remove usage of new Span constructor in favour of Tracer.startSpan

Type of change

Please delete options that are not relevant.

  • Test refactor (non-breaking change which fixes tests)

How Has This Been Tested?

  • Ran zipkin unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been modified

@david-luna david-luna requested a review from a team as a code owner October 1, 2024 16:32
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (f8ab559) to head (4d83339).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5030      +/-   ##
==========================================
- Coverage   93.39%   93.26%   -0.14%     
==========================================
  Files          46      317     +271     
  Lines         712     8194    +7482     
  Branches      120     1640    +1520     
==========================================
+ Hits          665     7642    +6977     
- Misses         47      552     +505     

see 266 files with indirect coverage changes

@david-luna david-luna requested a review from pichlermarc October 2, 2024 14:25
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thanks for working on this. 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 4, 2024
@pichlermarc pichlermarc enabled auto-merge October 4, 2024 08:36
@pichlermarc pichlermarc added this pull request to the merge queue Oct 4, 2024
Merged via the queue into open-telemetry:main with commit 4947c2d Oct 4, 2024
21 checks passed
@david-luna david-luna deleted the dluna/3597-reomve-span-constructor-exporter-zipkin branch November 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants