test(instrumentation): skip unwrap tests for esm #5153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
import-in-the-middle@1.11.1
brokeInstrumentation#disable()
functionality for ESM by introducing support to hook the same module multiple times (nodejs/import-in-the-middle#153) - this makes tests fail in #5045 which bumps the lock file to that version.This PR is to unblock updating by skipping the unwrap tests for ESM instrumentation. Going forward, we'll have to decide if the unwrapping-during-runtime is worth the complexity and maintenance overhead it introduces to every instrumentation package. Going through use-cases it seems like disabling/unwrapping is mostly used for testing - since the release of
import-int-the-middle@1.11.1
we also had 0 user reports that this functionality is broken, which leads me to believe that this feature is not of significant enough value to a significant portion our end-users.I'll open a follow-up issue to discuss this in-depth.
Short description of the changes
@opentelemetry/instrumentation