Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(instrumentation): skip unwrap tests for esm #5153

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 14, 2024

Which problem is this PR solving?

import-in-the-middle@1.11.1 broke Instrumentation#disable() functionality for ESM by introducing support to hook the same module multiple times (nodejs/import-in-the-middle#153) - this makes tests fail in #5045 which bumps the lock file to that version.

This PR is to unblock updating by skipping the unwrap tests for ESM instrumentation. Going forward, we'll have to decide if the unwrapping-during-runtime is worth the complexity and maintenance overhead it introduces to every instrumentation package. Going through use-cases it seems like disabling/unwrapping is mostly used for testing - since the release of import-int-the-middle@1.11.1 we also had 0 user reports that this functionality is broken, which leads me to believe that this feature is not of significant enough value to a significant portion our end-users.

I'll open a follow-up issue to discuss this in-depth.

Short description of the changes

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file internal labels Nov 14, 2024
@pichlermarc pichlermarc requested a review from a team as a code owner November 14, 2024 10:19
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (72c9af9) to head (abea31b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   93.18%   93.17%   -0.01%     
==========================================
  Files         315      314       -1     
  Lines        8086     8076      -10     
  Branches     1617     1622       +5     
==========================================
- Hits         7535     7525      -10     
  Misses        551      551              

see 10 files with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Nov 14, 2024
Merged via the queue into open-telemetry:main with commit d51fa95 Nov 14, 2024
19 checks passed
@pichlermarc pichlermarc deleted the renovate/all-patch branch November 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants