Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otlp-exporter-base): implement partial success handling #5183

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 20, 2024

Which problem is this PR solving?

Implements #3183 - OTLP's partial success responses were previously unhandled in our exporters. This PR adds handling for partial success that, when partial success is returned by the server it is logged as a warning.

Fixes #3183

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Existing tests
  • Added unit tests
  • Manual testing

@pichlermarc pichlermarc force-pushed the feat/response-handlers branch 3 times, most recently from c7fca82 to 9769867 Compare November 20, 2024 11:59
@pichlermarc pichlermarc force-pushed the feat/response-handlers branch from 9769867 to d2e5cd7 Compare November 20, 2024 12:02
@pichlermarc pichlermarc marked this pull request as ready for review November 20, 2024 12:07
@pichlermarc pichlermarc requested a review from a team as a code owner November 20, 2024 12:07
@pichlermarc pichlermarc added the spec-feature This is a request to implement a new feature which is already specified by the OTel specification label Nov 20, 2024
@pichlermarc pichlermarc added this to the OTLP Exporter GA milestone Nov 20, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (fd7f2d9) to head (697328c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5183   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         314      315    +1     
  Lines        7993     8012   +19     
  Branches     1611     1617    +6     
=======================================
+ Hits         7561     7579   +18     
- Misses        432      433    +1     
Files with missing lines Coverage Δ
...otlp-exporter-base/src/logging-response-handler.ts 100.00% <100.00%> (ø)
...ges/otlp-exporter-base/src/otlp-export-delegate.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Nov 28, 2024
Merged via the queue into open-telemetry:main with commit fc94e46 Nov 28, 2024
21 checks passed
@pichlermarc pichlermarc deleted the feat/response-handlers branch November 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:otlp-exporter-base spec-feature This is a request to implement a new feature which is already specified by the OTel specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle partial success responses from OTLP export services
2 participants