-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp-exporter-base): implement partial success handling #5183
Merged
pichlermarc
merged 9 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/response-handlers
Nov 28, 2024
Merged
feat(otlp-exporter-base): implement partial success handling #5183
pichlermarc
merged 9 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/response-handlers
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
force-pushed
the
feat/response-handlers
branch
3 times, most recently
from
November 20, 2024 11:59
c7fca82
to
9769867
Compare
pichlermarc
force-pushed
the
feat/response-handlers
branch
from
November 20, 2024 12:02
9769867
to
d2e5cd7
Compare
pichlermarc
added
the
spec-feature
This is a request to implement a new feature which is already specified by the OTel specification
label
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5183 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 314 315 +1
Lines 7993 8012 +19
Branches 1611 1617 +6
=======================================
+ Hits 7561 7579 +18
- Misses 432 433 +1
|
trentm
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:otlp-exporter-base
spec-feature
This is a request to implement a new feature which is already specified by the OTel specification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Implements #3183 - OTLP's partial success responses were previously unhandled in our exporters. This PR adds handling for partial success that, when partial success is returned by the server it is logged as a warning.
Fixes #3183
Type of change
How Has This Been Tested?