Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otlp-exporter-base): add http response body to exporter error #5204

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

When exporting via OTLP we currently don't include the response body recevied from the remote in the error we return. This makes it difficult for users to see what's wrong. This PR addresses this by adding the response to the data of the OTLPExporterError

Fixes #5201

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added assertion in unit tests

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (c9fa209) to head (06d4874).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5204      +/-   ##
==========================================
+ Coverage   94.58%   94.59%   +0.01%     
==========================================
  Files         314      314              
  Lines        7993     7993              
  Branches     1611     1611              
==========================================
+ Hits         7560     7561       +1     
+ Misses        433      432       -1     
Files with missing lines Coverage Δ
...xporter-base/src/transport/http-transport-utils.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review November 26, 2024 11:05
@pichlermarc pichlermarc requested a review from a team as a code owner November 26, 2024 11:05
@pichlermarc pichlermarc added this pull request to the merge queue Nov 27, 2024
Merged via the queue into open-telemetry:main with commit 3bf1284 Nov 27, 2024
22 checks passed
@pichlermarc pichlermarc deleted the feat/more-descriptive-http-exporter-error branch November 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make OTLPExporterError less cryptic by including the response body
2 participants