Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-confuse Nuxt build tooling by not using 'export *' in comments #5227

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

See #5218. Using export * in comments breaks some build tooling (specifically the tooling used by Nuxt) and breaks the build output.

Note for reviewers: This is weird and this is difficult to test, please use the reproducer I created for verifying that this actually fixes the problem. I also did not believe it at first when I narrowed it down to a comment. 😅

Fixes #5218

Short description of the changes

changes export * in comments to read wildcard export instead

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (c9b5bb0) to head (9db157e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5227      +/-   ##
==========================================
- Coverage   94.60%   94.59%   -0.02%     
==========================================
  Files         315      315              
  Lines        8012     8012              
  Branches     1617     1617              
==========================================
- Hits         7580     7579       -1     
- Misses        432      433       +1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review December 2, 2024 17:59
@pichlermarc pichlermarc requested a review from a team as a code owner December 2, 2024 17:59
@pichlermarc pichlermarc added the bug Something isn't working label Dec 2, 2024
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow.. that was a tricky one, thanks for fixing it!

@pichlermarc pichlermarc added this pull request to the merge queue Dec 3, 2024
Merged via the queue into open-telemetry:main with commit b0f73ea Dec 3, 2024
22 checks passed
@pichlermarc pichlermarc deleted the fix/export-comment branch December 3, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'OTLPTraceExporter' imported from /app/server/index.mjs
2 participants