refactor(resources): fix eslint warning #5383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-resources/src/utils.ts 17:39 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any ``` Ref open-telemetry#5365
chancancode
commented
Jan 27, 2025
| val !== null && typeof val === 'object' && typeof val.then === 'function' | ||
| val !== null && | ||
| typeof val === 'object' && | ||
| typeof (val as Partial<PromiseLike<R>>).then === 'function' | ||
| ); |
There was a problem hiding this comment.
Adding 'then' in val to the existing chain would also work (instead of doing the cast), and sometimes I prefer that for readability. However that does impose a tiny bit of additional runtime cost so I avoided it here.
There was a problem hiding this comment.
@david-luna resolved
For context: #5350 landed a similar fix so this PR isn't strictly necessary anymore, if the only goal is to get rid of the any (which #5350 did). This is slightly more precise and matches the intention of the code better.
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 310 310
Lines 7969 7969
Branches 1679 1679
=======================================
Hits 7554 7554
Misses 415 415
|
david-luna
approved these changes
Feb 5, 2025
david-luna
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fix the following eslint warning in the resources package:
Ref #5365
Short description of the changes
Use
unknowninstead.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: