fix(exporter-zipkin): remove deprecated url.parse
usage
#5390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Addresses the following deprecation/eslint warning:
Ref #5365
Short description of the changes
url.parse
is deprecated in favor ofnew URL()
.url.parse
do not get CVEs so at minimum using it in production code a security liability, if not an outright vulnerability.They do behave differently so it's often not a straightforward direct replacement. However, in this case, the only reason we are even calling
url.parse
is to extract a set of info to merge into the options we pass intohttp(s).request
.http(s).request
now takes a separate URL argument, so we can bypass that.So I think we should be able to make this change compatibly, outside of some weird edge cases that are probably not applicable here. @pichlermarc you worked on #5091 so let me know if you can think of anything relevant that you want to see tested.
It is worth noting in the CHANGELOG since this used to trigger a Node runtime deprecation warning with
--pending-deprecation
.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: