Autobump Collector VERSION to latest on build - #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nslaughter
changed the title
tylerbenson
reviewed
Jun 24, 2024
Replace the mechanism to fetch VERSION from remote versions.yaml with OTELCOL_VERSION placeholder. Add a new target set-otelcol-version to set the OpenTelemetry Collector version from go.mod. Modify the build target to depend on set-otelcol-version. Remove the update-collector-version target and its usage in the build target.
tylerbenson
reviewed
Jun 24, 2024
modified: .gitignore deleted: collector/VERSION
rapphil
approved these changes
Jul 16, 2024
rapphil
reviewed
Jul 16, 2024
| GIT_SHA=$(shell git rev-parse HEAD) | ||
| GOARCH ?= amd64 | ||
| GOBUILD=GO111MODULE=on CGO_ENABLED=0 installsuffix=cgo go build -trimpath | ||
| BUILD_INFO_IMPORT_PATH=main | ||
|
|
||
| LDFLAGS=-ldflags "-s -w -X $(BUILD_INFO_IMPORT_PATH).GitHash=$(GIT_SHA) -X $(BUILD_INFO_IMPORT_PATH).Version=$(VERSION) \ | ||
| LDFLAGS=-ldflags "-s -w -X $(BUILD_INFO_IMPORT_PATH).GitHash=$(GIT_SHA) -X $(BUILD_INFO_IMPORT_PATH).Version=$(OTELCOL_VERSION) \ |
There was a problem hiding this comment.
TIL variables in Makefiles are dynamically expanded.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the PR is to automate the Lambda Layer Collector build and release process by extracting version information from dependency files for the
LDFLAGSingo buildand store the information in theVERSIONfile where it can be used by processes (such as crafting release notes) where consistent version information is needed.