Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update nodejs lambda to the latest standards and packages #1469

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat: update nodejs lambda to the latest standards and packages #1469

merged 2 commits into from
Aug 19, 2024

Conversation

pragmaticivan
Copy link
Contributor

@pragmaticivan pragmaticivan commented Aug 14, 2024 •
edited
Loading

  • Adds support to lock files for predictable builds.
  • Update major version of lerna
  • Run npm run lint:fix

@pragmaticivan pragmaticivan requested a review from a team as a code owner August 14, 2024 16:08
@pragmaticivan pragmaticivan force-pushed the feat-update-nodejs-lambda-latest branch from 6cbf00d to c0fff92 Compare August 14, 2024 16:10
@pragmaticivan
Copy link
Contributor Author

Might need to consider that as a breaking change with the nodejs16.x removal

@tylerbenson tylerbenson added the javascript Pull requests that update Javascript code label Aug 14, 2024
@pragmaticivan pragmaticivan force-pushed the feat-update-nodejs-lambda-latest branch from da71761 to 2d4768d Compare August 15, 2024 21:50
tylerbenson
tylerbenson approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to removing node 16 support, especially if it's not supported by AWS anymore. Perhaps better as a separate PR though. Thanks for the contribution and look forward to more participation.

martinkuba
martinkuba approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@martinkuba martinkuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerbenson tylerbenson merged commit 91073e2 into open-telemetry:main Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@martinkuba martinkuba martinkuba approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pragmaticivan @tylerbenson @martinkuba