Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct metric type in OTLP exporter #250

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

golisai
Copy link
Contributor

@golisai golisai commented Jan 17, 2024

Description:
Fix to report the correct metric types in the OTLP exporter. Currently Gauge is being reported as Sum.

Link to tracking Issue: None

Testing:
Checked using the otlp log exporter


Metric #0
Descriptor:
     -> Name: http.client.duration.average
     -> Description:
     -> Unit: us
     -> DataType: Gauge
NumberDataPoints #0
Data point attributes:
     -> source.process.name: Str(kubelite)
     -> source.resolution_type: Str(PROCESS)
     -> dest.container.name: Str(coredns)
     -> source.workload.name: Str(snap.microk8s.daemon-kubelite)
     -> dest.image_version: Str(1.10.1)
     -> dest.namespace.name: Str(kube-system)
     -> dest.process.name: Str(coredns)
     -> dest.resolution_type: Str(K8S_CONTAINER)
     -> dest.workload.name: Str(coredns)
     -> dest.workload.uid: Str(0485c36b-283e-496e-af47-1a69545cd887)
     -> source.namespace.name: Str((unknown))
StartTimestamp: 2024-01-17 22:32:57.823206508 +0000 UTC
Timestamp: 2024-01-17 22:33:27.823206508 +0000 UTC
Value: 0.000177

Documentation: None

Copy link
Contributor

@yonch yonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@yonch yonch merged commit a902621 into open-telemetry:main Jan 18, 2024
11 checks passed
@golisai golisai deleted the gauge branch January 18, 2024 19:15
@golisai
Copy link
Contributor Author

golisai commented Jan 18, 2024

Thanks. @yonch with this patch we have all the fixes we are targeting for our release. Can you please cut a release tag?

@yonch
Copy link
Contributor

yonch commented Jan 18, 2024

👍 v0.10.2 is in progress in Github Actions: https://github.com/open-telemetry/opentelemetry-network/actions/runs/7575777545

@golisai
Copy link
Contributor Author

golisai commented Jan 18, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants