Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge should pull from v1beta1 too #2985

Closed
jaronoff97 opened this issue May 23, 2024 · 4 comments · Fixed by #3080
Closed

Bridge should pull from v1beta1 too #2985

jaronoff97 opened this issue May 23, 2024 · 4 comments · Fixed by #3080
Labels
enhancement New feature or request needs triage

Comments

@jaronoff97
Copy link
Contributor

Component(s)

opamp

Is your feature request related to a problem? Please describe.

The OpAMP Bridge currently only queries for v1alpha1 collectors, we should also check for v1beta1 now too!

Describe the solution you'd like

Modify the code to query for v1beta1 and v1alpha1

Describe alternatives you've considered

No response

Additional context

No response

@jaronoff97 jaronoff97 added enhancement New feature or request needs triage labels May 23, 2024
@yuriolisa
Copy link
Contributor

@jaronoff97, I can get this.

@jaronoff97
Copy link
Contributor Author

@yuriolisa my colleague has been working on this and should have a PR soon for it actually :)

@yuriolisa
Copy link
Contributor

@yuriolisa my colleague has been working on this and should have a PR soon for it actually :)

Great!! Thanks for the heads-up!

@jaronoff97
Copy link
Contributor Author

@gdfast is working on it :)

gdfast added a commit to gdfast/opentelemetry-operator that referenced this issue Jun 27, 2024
**Description**: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version

**Link to tracking Issue(s)**: open-telemetry#2985

**Testing**: Update

Documentation: n/a
jaronoff97 added a commit that referenced this issue Jul 9, 2024
* OpAMP Bridge: Applier support for OTel CRD v1beta1 API Version

**Description**: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version

**Link to tracking Issue(s)**: #2985

**Testing**: Update

Documentation: n/a

* Add chloggen entry

* Simplify list instances code

* Register v1beta1 types

* Register v1beta1 group version

---------

Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants