OpAMP Bridge: Applier support for OTel CRD v1beta1 API Version #3080
Conversation
**Description**: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version **Link to tracking Issue(s)**: open-telemetry#2985 **Testing**: Update Documentation: n/a
There was a problem hiding this comment.
two minor thoughts, certainly nothing blocking. Overall this looks great though! Pretty clean implementation. Were you able to confirm the behavior of the bridge when running in a cluster that has both v1alpha1 and v1beta1 collectors? We don't have any e2e tests for this today, but it would be great to confirm this manually.
Just wanted to note that I talked live with Jacob and he guided me through some manual, functional testing. Jacob is also adding e2e tests that will increase coverage. |
Description: Updates the opamp bridge's config applier interface and client to support opentelemetry.io/v1beta1, explicitly removing support for applying OpenTelemetryCollector configurations of the opentelemetry.io/v1alph1 version
Link to tracking Issue(s): 2985
Testing: Updated existing client and agent unit tests; functionally tested the bridge by running it and making sure it didn't hit any errors at steady state. Did the same after launching collectors with v1beta1 and v1alpha1 specs.
Documentation: n/a