Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set Service Port Protocol for Jaeger Receivers #117

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Explicitly set Service Port Protocol for Jaeger Receivers #117

merged 4 commits into from
Dec 1, 2020

Commits on Nov 28, 2020

  1. Explicitly set Service Port Protocol for Jaeger Receivers

    The servicePort created for each Jaeger receiver does not currently set a Protocol, and therefore defaults to TCP. Some Jaeger receiver protocols (i.e. thrift_binary and thrift_compact) are UDP based rather than TCP, and therefore the operator currently creates service port entries that cannot be used due to the protocol mismatch.
    KingJ committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    45b847d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f044a5c View commit details
    Browse the repository at this point in the history
  3. Set receiver port's protocol prior to appending to the list of ports

    Reduces code duplication by setting the port's protocol consistently, rather than conditionally based the supplied configuration.
    KingJ committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    7feb1d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Disambiguate transport protocol references

    Rename protocol to transportProtocol, where protocol refers to a transport protocol (i.e. TCP/UDP) to reduce ambiguity between transport protocols and application protocols.
    KingJ committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    1f1d851 View commit details
    Browse the repository at this point in the history