Set env vars correctly in workflow steps #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/150-set-env-vars-workflow-steps
branch
from
71ed0f2
to
e27dd67
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/150-set-env-vars-workflow-steps
branch
from
ee83d1d
to
e8307ec
Compare
|
This should now work: |
jpkrohling
commented
Dec 17, 2020
| @@ -70,6 +70,18 @@ func main() { | |||
|
|
|||
| // Add flags related to this operator | |||
| v := version.Get() | |||
| logger := zap.New(zap.UseFlagOptions(&opts)) | |||
There was a problem hiding this comment.
This has been moved here so that it logs the versions even when a Kubernetes isn't available.
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de