[autoinstrumentation] Add node and pod ip env vars automatically #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Mar 20, 2024
| @@ -33,7 +33,9 @@ const ( | |||
|
|
|||
| EnvPodName = "OTEL_RESOURCE_ATTRIBUTES_POD_NAME" | |||
| EnvPodUID = "OTEL_RESOURCE_ATTRIBUTES_POD_UID" | |||
| EnvPodIP = "OTEL_POD_IP" | |||
There was a problem hiding this comment.
is there an attribute name in the spec for the POD and NODE IPs?
we should consider putting these under OTEL_RESOURCE_ATTRIBUTES_
There was a problem hiding this comment.
I opted not to use OTEL_RESOURCE_ATTRIBUTES_ because I wasn't adding these values to the resource attributes. They are being added so that in Instrumentation users can to http://$(OTEL_NODE_IP):4318 or http://$(OTEL_POD_IP):4318 for their endpoints without having to specify any extra env vars.
There was a problem hiding this comment.
For semantic convention, there isn't a k8s.pod.ip or k8s.node.ip convention yet.
jaronoff97
reviewed
Mar 20, 2024
iblancasa
approved these changes
Mar 25, 2024
pavolloffay
approved these changes
Apr 2, 2024
| component: instrumentation | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add node and pod ips as env vars automatically |
There was a problem hiding this comment.
Could we list the env vars here as well?
jaronoff97
approved these changes
Apr 2, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…n-telemetry#2769) * Add node and pod ip env vars automatically * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add node IP and pod IP to env vars automatically. This makes them easy to reference in language-specific env vars if needed. Most of the changes are updates to tests.
Link to tracking Issue(s):
Related to #2180
Testing:
Unit and e2e tests
Documentation:
Updated the readme