Tolerations support in otelcol CRD #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l collectors on tainted nodes for both deployments and daemonsets. Signed-off-by: Vineeth Pothulapati <vineethpothulapati@outlook.com>
jpkrohling
reviewed
Jun 2, 2021
|
Tests are missing as well. |
… that are relevant only for specifc mode of deployments
jpkrohling
reviewed
Jun 4, 2021
pkg/collector/deployment_test.go
Outdated
| @@ -17,6 +17,8 @@ package collector_test | |||
| import ( | |||
| "testing" | |||
|
|
|||
| v1 "k8s.io/api/core/v1" | |||
There was a problem hiding this comment.
The import order is odd here.
jpkrohling
previously approved these changes
Jun 4, 2021
|
Could you please check the test failure? |
auto-merge was automatically disabled
June 6, 2021 09:07
Head branch was pushed to by a user without write access
jpkrohling
approved these changes
Jun 7, 2021
|
@jpkrohling it looks like mergify task post all checks is failing. :) |
6 tasks
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
Signed-off-by: Vineeth Pothulapati <vineethpothulapati@outlook.com>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Vineeth Pothulapati <vineethpothulapati@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for tolerations in otelcol CRD, This helps in running Otel collectors on tainted nodes for both deployments and daemon sets.
fixes: #186