Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete webhook #313

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Add delete webhook #313

merged 1 commit into from
Jun 24, 2021

Conversation

VineethReddy02
Copy link
Contributor

@VineethReddy02 VineethReddy02 commented Jun 15, 2021 •
edited
Loading

The delete webhook configures the failurePolicy: Ignore to delete otelcol successfully when the Otel operator isn't available
fixes: #56

@VineethReddy02 VineethReddy02 requested review from a team and dmitryax June 15, 2021 21:23
@VineethReddy02 VineethReddy02 changed the title Add delete webhook to fix delete otelcol when operator isn't available Add delete webhook Jun 15, 2021
jpkrohling
jpkrohling approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but could you please confirm you manually tested this?

@VineethReddy02
Copy link
Contributor Author

I tested this out manually i.e. Scaled-down operator deployment to 0 replicas and tried deleting the otelcol custom resource was able to delete CR successfully.

@jpkrohling jpkrohling merged commit 6d76f00 into open-telemetry:main Jun 24, 2021
@jpkrohling jpkrohling mentioned this pull request Jun 25, 2021
Merged
@VineethReddy02 VineethReddy02 mentioned this pull request Jun 25, 2021
Closed
6 tasks
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@VineethReddy02
Allow deletion of CRs when the operator isn't available (open-telemet…
5a5e2fa 
…ry#313)
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@VineethReddy02
Allow deletion of CRs when the operator isn't available (open-telemet…
56bcea6 
…ry#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deletion of resources shouldn't fail if the webhook server isn't available
2 participants
@VineethReddy02 @jpkrohling