Allow customizing security context #332
Conversation
pkg/collector/container.go
Outdated
| Args: args, | ||
| Env: envVars, | ||
| Resources: otelcol.Spec.Resources, | ||
| SecurityContext: &otelcol.Spec.SecurityContext, |
There was a problem hiding this comment.
Could you add a unit test, ensuring that a security context set at the CR will propagate down to the container?
There was a problem hiding this comment.
Sure. Im out for the weekend. Will do on Monday.
There was a problem hiding this comment.
Followed existing test for volumes and added a new one for security context. LMK if you think that's enough.
There was a problem hiding this comment.
Totally forgot about the doc... Another reason to automate it as soon as possible :-)
| // SecurityContext will be set as the container security context | ||
| // +optional | ||
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true | ||
| SecurityContext v1.SecurityContext `json:"securityContext,omitempty"` |
There was a problem hiding this comment.
Sorry for catching this only now, but this should be a pointer. Otherwise, we won't know when it's been specified explicitly by the user. We need this signal if we ever decide to change the default value we pass down to the containers.
pkg/collector/container.go
Outdated
| Args: args, | ||
| Env: envVars, | ||
| Resources: otelcol.Spec.Resources, | ||
| SecurityContext: &otelcol.Spec.SecurityContext, |
|
LGTM! |
Allow setting a custom security context on containers.
Allow setting a custom security context on containers.
Allow setting a custom security context on containers.
This allows users to customize the container security context settings. It's helpful when some collector features need elevated privileges.