Allow running daemonset in hostNetwork mode #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
allow-running-in-host-network
branch
5 times, most recently
from
bde5c7f
to
7af3df9
Compare
|
I believe this is all that is required to enable the feature so submitting for review but haven't tested locally in a real cluster yet. Will do that later today in a few hours and report back. |
dmitryax
previously approved these changes
Aug 13, 2021
owais
force-pushed
the
allow-running-in-host-network
branch
from
7af3df9
to
de358ff
Compare
|
Verified on a local cluster. Good to go. |
dmitryax
previously approved these changes
Aug 13, 2021
jpkrohling
reviewed
Aug 16, 2021
owais
force-pushed
the
allow-running-in-host-network
branch
from
515eb03
to
0099444
Compare
owais
force-pushed
the
allow-running-in-host-network
branch
from
0099444
to
4270cce
Compare
owais
force-pushed
the
allow-running-in-host-network
branch
from
4270cce
to
d8ecbfd
Compare
|
@jpkrohling added e2e test for daemonset+hostNetwork |
|
LGTM! Waiting for the tests to pass... |
|
@VineethReddy02 yeah these seem to be flaky tests. They fail randomly locally as well as on CI. I'm re-running the CI. Hopefully should be green in a few attempts. |
|
All green now @VineethReddy02 Thanks for the review. |
dmitryax
approved these changes
Aug 18, 2021
jpkrohling
approved these changes
Aug 19, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Allow running daemonset in hostNetwork mode * Added daemonset e2e tests
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Allow running daemonset in hostNetwork mode * Added daemonset e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.