Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added imagePullPolicy option to CRD #413

Merged

Conversation

mmatache
Copy link
Contributor

@mmatache mmatache commented Aug 25, 2021

Signed-off-by: Mihai Matache mihai.matache@sap.com

Fixes #411

Signed-off-by: Mihai Matache <mihai.matache@sap.com>
@mmatache mmatache requested review from a team and Aneurysm9 August 25, 2021 14:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 25, 2021

CLA Signed

The committers are authorized under a signed CLA.

@jpkrohling
Copy link
Member

Please, take a look at the EasyCLA failure.

@mmatache
Copy link
Contributor Author

@jpkrohling I've fixed the EasyCLA issue and managed to run make bundle. It turns out the issue is that operator-sdk v1.11 is not compatible with the project as it is now.

@@ -25,7 +25,7 @@ metadata:
operators.operatorframework.io/project_layout: go.kubebuilder.io/v2
repository: github.com/open-telemetry/opentelemetry-operator
support: OpenTelemetry Community
name: opentelemetry-operator.v0.33.0
name: opentelemetry-operator.v0.33.0-5-g3efd850
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file should be reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the changes, but they were made by the make bundle command. I hope this does not affect CI.

@jpkrohling jpkrohling enabled auto-merge (squash) August 26, 2021 15:37
@jpkrohling jpkrohling merged commit 036d678 into open-telemetry:main Aug 26, 2021
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
* Added imagePullPolicy option to CRD

Signed-off-by: Mihai Matache <mihai.matache@sap.com>

* updated container test

* Ran make bundle

* reverted changes to bundle
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Added imagePullPolicy option to CRD

Signed-off-by: Mihai Matache <mihai.matache@sap.com>

* updated container test

* Ran make bundle

* reverted changes to bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the imagePullPolicy attribute to the CR
2 participants