Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add envFrom to collector spec #419

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

ctison
Copy link
Contributor

@ctison ctison commented Sep 6, 2021

Summary

Add support for passing envFrom values into Collector's pods.

@ctison ctison requested review from a team and tigrannajaryan September 6, 2021 13:23
@VineethReddy02
Copy link
Contributor

Thanks for the PR @ctison

Can you add tests for the same in pkg/collector/*_test.go for all relevant K8s resources? Also, we maintain the collector CR specs i.e. all the fields that can be configured here. Can you add the envFrom field in this doc?

@VineethReddy02
Copy link
Contributor

@ctison Can you update this PR with the required changes? We would love to get this merged. :)

@ctison
Copy link
Contributor Author

ctison commented Sep 28, 2021

@jpkrohling jpkrohling merged commit 05081b8 into open-telemetry:main Oct 4, 2021
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
* feat: add `envFrom` to collector spec

* chore: add docs and tests
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* feat: add `envFrom` to collector spec

* chore: add docs and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants