Add docker image containing nodejs auto instrumentation #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Nov 5, 2021
| @@ -0,0 +1,12 @@ | |||
| import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'; | |||
| import { OTLPTraceExporter } from '@opentelemetry/exporter-otlp-grpc'; | |||
There was a problem hiding this comment.
From what I understand NodeJS doesn't support env vars like OTEL_TRACES_EXPORTER yet. When it does, we would remove this sort of hard-coding.
There was a problem hiding this comment.
Should this be an issue on this repository then?
anuraaga
force-pushed
the
nodejs-autoinstrumentation-docker
branch
from
46586bd
to
38982a9
Compare
jpkrohling
reviewed
Nov 5, 2021
| @@ -0,0 +1,12 @@ | |||
| import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'; | |||
| import { OTLPTraceExporter } from '@opentelemetry/exporter-otlp-grpc'; | |||
There was a problem hiding this comment.
Should this be an issue on this repository then?
|
@anuraaga how does the injection of nodeJS instrumentation to an application work? Could you please briefly describe here what the operator will have to do to enable the instrumentation automatically? |
|
@pavolloffay The code is in #507 :) But if it would help to also have text explanation let me know |
pavolloffay
approved these changes
Nov 8, 2021
jpkrohling
approved these changes
Nov 8, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created image: https://github.com/anuraaga/opentelemetry-operator/pkgs/container/opentelemetry-operator%2Fautoinstrumentation-nodejs
I think the autoinstrumentation wrapper could be pushed to js-contrib though we'll still need to package something with Docker. Hopefully it's OK to include it here for now to try out the autoinstrumentation experience.
@pavolloffay @jpkrohling
/cc @dyladan
Would be used by #507